On Fri, 12 Mar 2010, Daniel Convissor wrote: > On Fri, Mar 12, 2010 at 06:53:49PM -0500, Eric Stewart wrote: > > > > If I'm given the choice of those differences being in one file or in three > > different files (5.2, 5.3, 6.0)? I choose one file. Even if that files is > > more complex. It's still one file. One commit. One place to look for > > problems. And you get the bonus of being able to see the actual differences > > of the same functionality in different versions of PHP all in one place. > > Agreed. > > It seems we'll need not only a ==VERSION== section of some sort, but a > ==VERSION_OUTPUT== type of thing as well. For example, when things get > deprecated. The test suite needs to ensure that the function works > normally in 5.2 but throws a deprecated warning in 5.3.
I'd rather see two test cases for this then. Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
