Hi! On 9/2/11 1:14 PM, Johannes Schlüter wrote:
Looking at the tests we have: Most tests are written with mysqlnd in focus. mysqlnd is what we (Oracle/MySQL) test the most in PHP perspective for quite some time already. By making mysqlnd the default we remove one moving piece out of the test equation which simplifies tests[1]. (we still have multiple server versions to keep in mind ...)
Are you implying you would no longer fix failures on libmysql? If so, we should announce libmysql is unsupported and I definitely am against doing anything like this in 5.4. If you are not meaning this, then absolutely nothing changes with regard to unit tests - they still must pass on both modes.
different combinations (and make the tests more complex to cover multiple cases) or focus on having a good and stable default which behaves the same on all platforms.
We should focus on having unit tests passing, otherwise there's no point in having them. If we do not drop libmysql support, we should have exactly the same results in libmysql as we have in mysqlnd. Otherwise it is called "unsupported configuration". If the plan is to keep pretense of supporting libmysql while actually neglecting to do fixes and fix tests for it in hope that people would eventually switch - this is not the right way to do it.
-- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
