Hi Remi, Thanks for the PR. I'll merge it as soon as I've been able to test it, as the class should respect the definition of the method in the interface.
Regarding the change in behaviour, I think the patch https://bugs.php.net/patch-display.php?bug=67064&patch=bug67064-BC&revision=1402667581 should definitely be applied. Currently the engine is doing magic stuff by modifying the parameters that are passed to the function. i.e. you call count() with no parameters and it arrives at the function with parameters. \o/ Even if that wasn't a BC break, having magic behaviour in a language is very, very bad. cheers Dan On 23 July 2014 09:57, Remi Collet <r...@fedoraproject.org> wrote: > Le 23/07/2014 10:26, Remi Collet a écrit : > >> Both solution "should" fix this: >> - adding the count_elements handler >> - accepting the optional mode > > Both works. > >> But, Reflection still not correct, and count($a) still raise the > > IT is ok (sorry for the noise, tested with a bad path...) > >> I think this is not consistent (internal vs userland) > > Inconsistency is : > > $a->count() call the method (with the optional arg), > count($a) call the handler > > > Rmei. > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
