On Thu, Oct 30, 2014 at 10:57 PM, John Bafford <jbaff...@zort.net> wrote: > Hi, > > I would like to propose the creation of a team to triage the pull requests on > GitHub, to help ensure that the pull requests are handled in a timely manner. > I am also volunteering to lead such a team, should the RFC be approved. > > https://wiki.php.net/rfc/github-pr > > PHP’s GitHub repository has over 180 open pull requests. Many of these are > bug fixes or new tests that should be incorporated into PHP, but have not > been because the PRs aren’t being regularly monitored. As a result, the large > number of open pull requests may also be discouraging contributions, as > potential contributors may see that pull requests are not being acted on and > decline to submit changes. >
Hi, I like the label idea, it will help having a nice overall look on the PRs. When I myself find some time, I mainly browse through bugs.php.net and fix things and close issues. Everything is matter of time and knowledge. Having people with time to review PRs, and knowledge about internals code and the PR code quality, is pretty hard to find. Like Tyrael said, one could always ping an RM to finally merge the PR, or even review it. We (as RMs) have already been pinged back in time by people pushing their PR. This is normal situation, I think everyone is responsible of his own PR, nd responsible of pushing it into the final step. But as we all volunteer into the PHP project, it may sometimes be hard to find time for. Not bad, a PR is obviously never lost until cleaned. PS : our merging strategy as well is not easy to get, knowing some PRs may conflict while merge into the diverging master code. Julien.P -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
