Hi Davey,

On Sun, Oct 16, 2016 at 6:08 PM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote:
> I was planning to fix session_start() behaviors by PHP 7.1, but I
> forgot to do this completely. Partial fix is merged currently.
> Following PR makes session_start() return FALSE when it cannot start
> session always.
> https://github.com/php/php-src/pull/2167
> In short, this patch fixes number of session_start()'s insane behaviors.

I think I've finished the patch for now.

There are many other places that I would like to improve/fix error
handlings. e.g. Session save handlers. This patch is too large
already. I'll fix them in master.

The patch could be divided into "session_start() error handling fix
only" and "other session core error handling issues". It may be good
to include "session_start() error handling fix only" for PHP 7.1, but
other fixes won't bother correct PHP scripts. Please note that
session_start() fix in PHP-7.1 and master branch is partial fix. I
suggest to merge "session_start() error handling fix only" at least,
but it's your choice.

Please let me know when you decide what to do or merge appropriate
patch from the PR.

BTW, I expect UnitTest failures, framework/etc, that test session
module functionalities. They have tests for failure cases. Even if
there are minor BC issues (UnitTests report error, bad code emit
errors), this fix must be done at some point anyway.


Yasuo Ohgaki

PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to