On 12.02.2018 at 00:03, Pedro Lacerda wrote:

> So a new function check_strict_types() was needed to expose
> ZEND_ARG_USES_STRICT_TYPES() enabling .phpt tests to check for it in the
> --SKIPIF-- section if needed.

Umm, I wonder whether a magic constant (say, `__STRICT_TYPES__`) would
be more appropriate.

> And the implementation draft is at this repository:
> 
> https://github.com/php/php-src/compare/master...pslacerda:experimental/strict_testing?diff=split

Please have a look at the die()s – "skip" is omitted, but the rest of
the message is printed.  Something like

  die('skip strict_types is not enabled');

might be more appropriate.

-- 
Christoph M. Becker

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to