Hi! > My proposal is to run all tests with and without strict_types, skipping if > necessary, and increasing the code coverage. Depending of you overral > reception I'll create an RFC for it.
I am not sure what would be the advantage of this. Beyond testing strict_types functionality itself (which of course should have its own unit tests), the tests that test standard functioning of any function would either supply correct arguments and then strict_types would be irrelevant (provided it works as supposed to, which is tested by its own tests) or provide incorrect arguments, and then strict_type tests should be different from regular ones since the errors would be different, so we'd have to write separate tests. The only class of errors that could be found this way would be if we somehow made such a mistake in defining the arguments of certain function that strict_type version of it doesn't work but regular version works fine. Which I guess is possible but does it worth the effort to convert all tests? Not sure. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
