On 2020/3/24 3:37, Jacob Pan wrote:
On Sun, 22 Mar 2020 09:29:32 +0800> Lu Baolu<[email protected]>  wrote:

On 2020/3/21 7:27, Jacob Pan wrote:
Memory type related flags can be grouped together for one simple
check.

---
v9 renamed from EMT to MTS since these are memory type support
flags. ---

Signed-off-by: Jacob Pan<[email protected]>
---
   include/uapi/linux/iommu.h | 5 ++++-
   1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/iommu.h b/include/uapi/linux/iommu.h
index 4ad3496e5c43..d7bcbc5f79b0 100644
--- a/include/uapi/linux/iommu.h
+++ b/include/uapi/linux/iommu.h
@@ -284,7 +284,10 @@ struct iommu_gpasid_bind_data_vtd {
        __u32 pat;
        __u32 emt;
   };
-
+#define IOMMU_SVA_VTD_GPASID_MTS_MASK
(IOMMU_SVA_VTD_GPASID_CD | \
+                                        IOMMU_SVA_VTD_GPASID_EMTE
| \
+                                        IOMMU_SVA_VTD_GPASID_PCD
|  \
+
IOMMU_SVA_VTD_GPASID_PWT)
As name implies, can this move to intel-iommu.h?

I also thought about this but the masks are in vendor specific part of
the UAPI.


I looked through this patch series. It looks good to me. I will do some
code style cleanup and take it to v5.7. I am not the right person to
decide whether include/uapi/linux/iommu.h is the right place for this,
so I will move it to Intel IOMMU driver for now.

Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to