On 03/05/2018 05:49 AM, Heldt-Sheller, Nathan wrote:
>
> Hi Devs,
>
>
>
> It seems the various .dat files are no longer being .gitignored.
Since they are not in the /out dir, but are still rebuilt by scons,
shouldn’t they be left out? Is there a reason for this?
>
>
>
> Thanks,
> Nathan
Hi
I unsure I got your point, but if you're talking about the.dat files in
sources,
It's because those files has been regenerated and differing since
"previous state"
so they should be committed (and checked if possible),
then they will not appear until next changes (in .json or converter tool)
For instance check:
https://gerrit.iotivity.org/gerrit/#/c/21851/
resource-encapsulation: Sync JSON and CBOR files
To avoid local changes on build,
let's commit the updated .dat files (using json2cbor)
Reminder, It's developer dutty to commit those files on each changes on
json source or any change that produce a different result
This way we're not leaving inconsistant binary files in tree.
JSON file was not modified because it is already in UNIX format
Note: those files may need to be updated to support current ACL
(and committed by security team, check status of json and dat files)
Bug: https://jira.iotivity.org/browse/IOT-2310
--
mailto:philippe.co...@osg.samsung.com gpg:0x467094BC
https://blogs.s-osg.org/author/pcoval/
_______________________________________________
iotivity-dev mailing list
iotivity-dev@lists.iotivity.org
https://lists.iotivity.org/mailman/listinfo/iotivity-dev
