On 9/6/06, Matthew Laird <[EMAIL PROTECTED]> wrote: > I did a dump of the network settings on this new machine and an existing > machine and the only difference I can see is this "Set in Progress" line > is set to "Set In Progress" on the new machine and "Set Complete" on the > existing machine. >
On my hardware, I have to use the commit and the unlock for everything. I've modified the code to do that unconditionally. Also I changed the length "1" parameter on this function call __set_lan_param(intf, chan, IPMI_LANP_SET_IN_PROGRESS, &val, 1, 0);. Before it was a "0" for the UNLOCK call. See also this thread: http://www.mail-archive.com/ipmitool-devel@lists.sourceforge.net/msg00095.html regards, dan carpenter Index: lib/ipmi_lanp.c =================================================================== RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_lanp.c,v retrieving revision 1.49 diff -u -r1.49 ipmi_lanp.c --- lib/ipmi_lanp.c 28 Jun 2006 21:21:33 -0000 1.49 +++ lib/ipmi_lanp.c 8 Sep 2006 03:17:16 -0000 @@ -388,15 +388,12 @@ static void ipmi_lanp_unlock(struct ipmi_intf * intf, uint8_t chan) { - uint8_t val = IPMI_LANP_WRITE_COMMIT; - int rc; + uint8_t val; - rc = __set_lan_param(intf, chan, IPMI_LANP_SET_IN_PROGRESS, &val, 1, 0); - if (rc < 0) { - lprintf(LOG_DEBUG, "LAN Parameter Commit not supported"); - val = IPMI_LANP_WRITE_UNLOCK; - __set_lan_param(intf, chan, IPMI_LANP_SET_IN_PROGRESS, &val, 0, 0); - } + val = IPMI_LANP_WRITE_COMMIT; + __set_lan_param(intf, chan, IPMI_LANP_SET_IN_PROGRESS, &val, 1, 0); + val = IPMI_LANP_WRITE_UNLOCK; + __set_lan_param(intf, chan, IPMI_LANP_SET_IN_PROGRESS, &val, 1, 0); } /* set_lan_param - Wrap LAN parameter write with set-in-progress lock ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
