Hi, Here's the second batch of outstanding patches/issues. Unless someone objects, review comments and feedback should be sent within 2 weeks.
Thank you very much for your help, :-) Carol ---------------------------------- 10) Rauf Kuliyev reported an issue on 6/17/07 with a core dump using the lanplus interface: http://sourceforge.net/mailarchive/message.php?msg_name=6b3582f60706170153y7d7da4f1p5622483acbdc4e38%40mail.gmail.com Brian Selecki investigated and indicated that the issue was a free() on uninitialized pointers. Brian, could you please send in the patch for this and for the other fwrite() issue you'd reported (#6 on the list I sent out Monday)? Thank you very much :-) 11) Joshua Neal sent in a fix on 7/2/07 for raw i2c command. http://sourceforge.net/mailarchive/message.php?msg_name=2C369A47F6C03147B71C36F9100BFB421367A7%40RWCEXC01.HQ.DeCru.com My Comments: What's currently there in ipmi_rawi2c_main() looks wrong to me and Joshua's patch looks like a fix. If he's tested it and no one else has a comment, I would suggest we put this in. 12) Harshad Prabhu sent in 4 patches on 7/10/07. The two for ipmi.h and ipmi_strings.c are in cvs (he sent them in separately on 8/2/07) but the open.c and ipmi_sol.c patches aren't in yet. http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200707&viewday=10 My comments: Regarding the open.c patch, I believe the patch is adding support for a special case which could potentially break things for more general cases. I feel like there should be a better way to accomplish the intended goal? Regarding the ipmi_sol.c patch, it adds retries before giving up. If that would help provide more network latency/fault tolerance in SOL, it sounds like it might be a good idea at first glance but maybe other folks have looked into this more and have a different opinion? 13) Al Chu wrote on 7/11/07 that he might write a patch to add the state of user enabled/disabled to the user list command. Al, did you ever get around to this? :-) http://sourceforge.net/mailarchive/message.php?msg_name=1184172062.6028.24.camel%40cardanus.llnl.gov 14) Tony Ernst sent in a patch on 8/6/07 to improve usage info returned and to fix a segfault in "lan set". http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&max_rows=25&style=nested&viewmonth=200708&viewday=6 My comments: any improvements to usage or documentation are terrific. I haven't played around with lan set commands enough to trip over any segfaults but if there are some, it'd be great to get rid of 'em. :) ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
