Hi Carol,
Please find my comments below
**********************************************
12) Harshad Prabhu sent in 4 patches on 7/10/07. The two for ipmi.h
and ipmi_strings.c are in cvs (he sent them in separately on 8/2/07) but
the open.c and ipmi_sol.c patches aren't in yet.
http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&m
ax_rows=25&style=nested&viewmonth=200707&viewday=10
<http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&;
max_rows=25&style=nested&viewmonth=200707&viewday=10>
My comments: Regarding the open.c patch, I believe the patch is adding
support for a special case which could potentially break things for more
general cases. I feel like there should be a better way to accomplish
the intended goal? Regarding the ipmi_sol.c patch, it adds retries
before giving up. If that would help provide more network latency/fault
tolerance in SOL, it sounds like it might be a good idea at first glance
but maybe other folks have looked into this more and have a different
opinion?
**********************************************
1) Open.c patch was very much required for firmware upgrade via KCS
interface because when we are using KCS to do the HPM upgrade we get
0x80 which is a valid completion code (HPMFWUPG_COMMAND_IN_PROGRESS)
where the return response values are important (which cannot be
ignored).The earlier code checks the completion code and if its not ZERO
does not copy any response data so the upper layer does not get the
required information. So rather then checking just the completion code
we check the return data length and copy the contents. Hopefully this
should not break anything.
*** If we are doing HPM FIRMWARE UPGRADE VIA KCS then this is VERY MUCH
REQUIRED as HpmfwupgUploadFirmwareBlock function returns VALID response
data even when the completion code is 0x80.
2) This was added for as you mentioned above, there were instances when
the payload is reset sometimes Network takes more time to establish the
SOL session. As we give UP for the first instance we added some more
retries which could make sure that BMC is down before closing the SOL
session.
Please let me know if you need any more information.
Cheers,
Harshad
PS : Thanks a lot for taking all the pain for going through individual
patches to ensure that we have a successful ... 1.8.10 release :-)
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]> ] On Behalf Of
Carol Hebert
Sent: Thursday, June 12, 2008 5:37 AM
To: ipmitool-devel@lists.sourceforge.net
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]
Subject: [Ipmitool-devel] ipmitool 1.8.10 - Second patch batch
Hi,
Here's the second batch of outstanding patches/issues. Unless someone
objects, review comments and feedback should be sent within 2 weeks.
Thank you very much for your help, :-)
Carol
----------------------------------
10) Rauf Kuliyev reported an issue on 6/17/07 with a core dump using
the lanplus interface:
http://sourceforge.net/mailarchive/message.php?msg_name=6b3582f607061701
53y7d7da4f1p5622483acbdc4e38%40mail.gmail.com
<http://sourceforge.net/mailarchive/message.php?msg_name=6b3582f60706170
153y7d7da4f1p5622483acbdc4e38%40mail.gmail.com>
Brian Selecki investigated and indicated that the issue was a free() on
uninitialized pointers. Brian, could you please send in the patch for
this and for the other fwrite() issue you'd reported (#6 on the list I
sent out Monday)? Thank you very much :-)
11) Joshua Neal sent in a fix on 7/2/07 for raw i2c command.
http://sourceforge.net/mailarchive/message.php?msg_name=2C369A47F6C03147
B71C36F9100BFB421367A7%40RWCEXC01.HQ.DeCru.com
<http://sourceforge.net/mailarchive/message.php?msg_name=2C369A47F6C0314
7B71C36F9100BFB421367A7%40RWCEXC01.HQ.DeCru.com>
My Comments: What's currently there in ipmi_rawi2c_main() looks wrong
to me and Joshua's patch looks like a fix. If he's tested it and no one
else has a comment, I would suggest we put this in.
12) Harshad Prabhu sent in 4 patches on 7/10/07. The two for ipmi.h
and ipmi_strings.c are in cvs (he sent them in separately on 8/2/07) but
the open.c and ipmi_sol.c patches aren't in yet.
http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&m
ax_rows=25&style=nested&viewmonth=200707&viewday=10
<http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&;
max_rows=25&style=nested&viewmonth=200707&viewday=10>
My comments: Regarding the open.c patch, I believe the patch is adding
support for a special case which could potentially break things for more
general cases. I feel like there should be a better way to accomplish
the intended goal? Regarding the ipmi_sol.c patch, it adds retries
before giving up. If that would help provide more network latency/fault
tolerance in SOL, it sounds like it might be a good idea at first glance
but maybe other folks have looked into this more and have a different
opinion?
13) Al Chu wrote on 7/11/07 that he might write a patch to add the state
of user enabled/disabled to the user list command. Al, did you ever
get around to this? :-)
http://sourceforge.net/mailarchive/message.php?msg_name=1184172062.6028.
24.camel%40cardanus.llnl.gov
<http://sourceforge.net/mailarchive/message.php?msg_name=1184172062.6028
.24.camel%40cardanus.llnl.gov>
14) Tony Ernst sent in a patch on 8/6/07 to improve usage info returned
and to fix a segfault in "lan set".
http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&m
ax_rows=25&style=nested&viewmonth=200708&viewday=6
<http://sourceforge.net/mailarchive/forum.php?forum_name=ipmitool-devel&;
max_rows=25&style=nested&viewmonth=200708&viewday=6>
My comments: any improvements to usage or documentation are terrific.
I haven't played around with lan set commands enough to trip over any
segfaults but if there are some, it'd be great to get rid of 'em. :)
------------------------------------------------------------------------
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
<http://sourceforge.net/services/buy/index.php>
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
<https://lists.sourceforge.net/lists/listinfo/ipmitool-devel>
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
