On Wed, Mar 27, 2013 at 12:53 PM, Zdenek Styblik <zdenek.styb...@gmail.com> wrote: > On Wed, Mar 27, 2013 at 12:35 PM, <dick.detwei...@emerson.com> wrote: >> Hi all, >> > > Hello Dick, > >> Styblik indicates via a comment yesterday that the patches I submitted last >> September for this issue will not be added to ipmitool saying " I'm afraid >> fix will be, well, complicated." >> > > yep, that's what I said. However, I didn't say issue won't be fixed. > >> I believe the patches I sent were a complete fix. We have been using them >> since September without issue. > > Despite your patch does fix issue in question, there is no need to > "fix", or modify in any other way, 'src/ipmishell.c', because it isn't > broken. But 'lib/ipmi_delloem.c' apparently is. > >> We would much rather use ipmitool without patches rather than keep patches >> around that fix generic issues like this. > > If other modules were affected, that would be a generic issue. But it > seems to me they're not. So I would say it's a 'lib/ipmi_delloem.c' > issue. > >> What else is required to get these changes into ipmitool? > > Re-write 'lib/ipmi_delloem.c' a bit, resp. change the way it handles > argc/argv. >
You know what? If you have time and willing to try something out, try to change following in 'lib/ipmi_delloem.c': ~~~ -static int current_arg = 0; +int current_arg = 0; ~~~ And see whether it doesn't break normal operation of 'lib/ipmi_delloem.c' and whether it fixes your/reported issue as well. That's the quickest/easiest fix that comes, resp. I had for some time, in my mind. I obviously haven't tried it, but I would (eventually). Z. > Best regards, > Z. > >> >> Thanks, >> Dick Detweiler >> ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
