On Wed, Mar 27, 2013 at 1:07 PM, <dick.detwei...@emerson.com> wrote: > OK - will let you know what we find. > > Thanks Z, > > Richard Detweiler | T 256-261-6550 >
Hello Richard, any progress on this one? Thanks, Z. > > -----Original Message----- > From: Zdenek Styblik [mailto:zdenek.styb...@gmail.com] > Sent: Wednesday, March 27, 2013 7:07 AM > To: Detweiler, Dick [NETPWR/AVOCENT/AL] > Cc: ipmitool-devel@lists.sourceforge.net > Subject: Re: [ ipmitool-Bugs-3571570 ] delloem exec file won't handle more > than one command > > On Wed, Mar 27, 2013 at 12:53 PM, Zdenek Styblik <zdenek.styb...@gmail.com> > wrote: >> On Wed, Mar 27, 2013 at 12:35 PM, <dick.detwei...@emerson.com> wrote: >>> Hi all, >>> >> >> Hello Dick, >> >>> Styblik indicates via a comment yesterday that the patches I submitted last >>> September for this issue will not be added to ipmitool saying " I'm afraid >>> fix will be, well, complicated." >>> >> >> yep, that's what I said. However, I didn't say issue won't be fixed. >> >>> I believe the patches I sent were a complete fix. We have been using them >>> since September without issue. >> >> Despite your patch does fix issue in question, there is no need to >> "fix", or modify in any other way, 'src/ipmishell.c', because it isn't >> broken. But 'lib/ipmi_delloem.c' apparently is. >> >>> We would much rather use ipmitool without patches rather than keep patches >>> around that fix generic issues like this. >> >> If other modules were affected, that would be a generic issue. But it >> seems to me they're not. So I would say it's a 'lib/ipmi_delloem.c' >> issue. >> >>> What else is required to get these changes into ipmitool? >> >> Re-write 'lib/ipmi_delloem.c' a bit, resp. change the way it handles >> argc/argv. >> > > You know what? If you have time and willing to try something out, try to > change following in 'lib/ipmi_delloem.c': > ~~~ > -static int current_arg = 0; > +int current_arg = 0; > ~~~ > > And see whether it doesn't break normal operation of 'lib/ipmi_delloem.c' and > whether it fixes your/reported issue as well. > That's the quickest/easiest fix that comes, resp. I had for some time, in my > mind. I obviously haven't tried it, but I would (eventually). > > Z. > >> Best regards, >> Z. >> >>> >>> Thanks, >>> Dick Detweiler >>> ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
