On Mon, Apr 1, 2013 at 9:03 PM, Dan Gora <d...@adax.com> wrote: > On Mon, Apr 1, 2013 at 3:54 PM, Zdenek Styblik <zdenek.styb...@gmail.com> > wrote: >> Dan, >> >> here is what I see wrong with this patch: >> >> * it touches/modifies more than just help >> * ``printf("Sensor Type %s not found.\n", type);'' -> ``lprintf(LOG_ERR, >> ...);'' >> >> I find the following, despite not covered/modified by the patch, to be >> disputable as well: ``printf("Sensor Types:\n");''. I think this >> should go to ``lprintf(LOG_NOTICE, ...);''. Just a note/observation. >> > > So just change these: > if (sensor_type != x) { > + printf("Sensor Type %s not found.\n", type); > printf("Sensor Types:\n"); > > to use lprintf(LOG_NOTICE, ..)? > > Ok, no problem.. I'll fix this. > > thanks > dan
lprintf(LOG_ERR, "Sensor Type %s not found.", type); I presume this is "help" context, but I definitely should check it in application context: lprintf(LOG_NOTICE, "Sensor Types:"); for (x = 1; x < SENSOR_TYPE_MAX; x += 2) { lprintf(LOG_NOTICE, "\t%-25s %-25s", sensor_type_desc[x], sensor_type_desc[x + 1]); } Funny enough, I see a lot of help output going on LOG_ERR in 'lib/ipmi_sdr.c' instead of LOG_NOTICE. *sigh* Regards, Z. ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel