On Thu, Apr 4, 2013 at 6:52 PM, Dan Gora <d...@adax.com> wrote: > On Thu, Apr 4, 2013 at 9:48 AM, Zdenek Styblik <zdenek.styb...@gmail.com> > wrote: >> On Fri, Mar 22, 2013 at 1:15 AM, Dan Gora <d...@adax.com> wrote: >>> Fixed the formatting of the help command to make it clearer what >>> options the sdr command has. >>> >> >> Ok, I did take a closer look at this diff: >> 1st part - useless and won't be committed >> 2nd part - we've talked about it already, it will be changed to >> lprintf(LOG_ERR, ...); ok to commit after the change >> 3rd part - sorry, but NACK. >> 4th part - ok to commit > > Ok, I really have no idea what "parts" you are referring to here. > Also, can you give a reason for NACKing whatever it is that you are > NACKing? > > thanks > dan
Sure. I've found two issues with help "update". The first is, I don't like new help output very much, to be honest. That doesn't mean you should re-work it. Let me come up with my version. The second issue I have is formatting. I understand you want to improve code formatting and I'm all for that. But replacing tabs with (one) white space and/or removing white spaces etc.? I really don't see it as a way to go. ~~~ <this is tabbed>lprintf(LOG_ERR, "whoo, where does this belong?" <this is tabbed>whatever_is_here ~~~ I don't find it very nice, no. If anything, string passed to printf/lprintf can be split. Does it make sense for something like sentences or some long text? I'm not sure. And if I remember correctly, even GNU coding standards, which are considered ancient and obsolete nowadays, allow lines over 80 chars if there is no (intelligent?) way to split it. *shrug* Regards, Z. ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
