Hi all, attached is one more, and hopefully last, iteration on SDR help update. The most notable changes from previous version: * LOG_ERR -> LOG_NOTICE * added error messages ``Not enough parameters given.'' * removed help text about how to define/input range in "small" help print-out as it looked awful and out of place * added handling of 'sdr fill INVALID_SUBCMD' case
Have a nice weekend, Z. -- Zdenek Styblik email: zdenek.styb...@gmail.com jabber: zdenek.styb...@gmail.com On Wed, Apr 10, 2013 at 10:37 AM, Ales Ledvinka <aledv...@redhat.com> wrote: > ack Z. > > ----- Original Message ----- > From: "Zdenek Styblik" <zdenek.styb...@gmail.com> > To: "Dan Gora" <d...@adax.com> > Cc: "ipmitool-devel" <ipmitool-devel@lists.sourceforge.net> > Sent: Tuesday, April 9, 2013 9:31:02 AM > Subject: Re: [Ipmitool-devel] [PATCH 1/3] Fixed help for sdr command. > > On Fri, Mar 22, 2013 at 1:15 AM, Dan Gora <d...@adax.com> wrote: >> Fixed the formatting of the help command to make it clearer what >> options the sdr command has. >> > > Hello, > > attached is diff and output of my take on 'sdr help'. Diff > incorporates all proposed changes to 'sdr help'. Originally, changes > were split into two diffs. To be honest, it's not that much different > from the original, but there are differences. > I particularly didn't like this ``"list | elist [option]. Available > options are:");'', because I think it's pointless and if not > pointless, then ugly to put it inline. Another difference is 'sdr get' > actually requires Sensor_ID to be supplied, so '<...>' has to be used > instead of '[...]'. There are some other changes, see the diff. > Since I'm not a native English speaker, it makes sense if somebody who > is checks spelling etc. > > Best regards, > Z. > > ------------------------------------------------------------------------------ > Precog is a next-generation analytics platform capable of advanced > analytics on semi-structured data. The platform includes APIs for building > apps and a phenomenal toolset for data science. Developers can use > our toolset for easy data analysis & visualization. Get a free account! > http://www2.precog.com/precogplatform/slashdotnewsletter > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
ipmi_sdr.c-main_help_update.diff
Description: Binary data
------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
