I fully agree with Dan in that there is no good reason to change existing indentation for code. It simply obfuscates real changes and makes application of patches problematic.
-- Jim Mankovich | jm...@hp.com (US Mountain Time) -- On 4/22/2013 11:11 AM, Dan Gora wrote: > On Mon, Apr 22, 2013 at 5:24 AM, Zdenek Styblik > <zdenek.styb...@gmail.com> wrote: >> Hello, >> >> hopefully, I haven't missed anything important from this patch. I >> think it's safe to say one lesson, and "rule", from this patch is not >> to mix fixes and indentation/formatting changes together. >> Anyway, that's not the reason for this e-mail. My impression of >> ipmi_fru_picmg_ext_print() is - it's a hell part of the code. And what >> I don't understand is why it isn't split into functions. Three levels >> of switch(), really? It definitely can and should be split. And hell, >> I'd do it eventually, but only if somebody can test it. I don't posses >> hardware to test it. Indentation is really ugly in this part(including >> three levels of switch() and alike), resp. way beyond acceptable. >> However, the solution isn't to remove indentation and cram the code. >> The solution seems to be split this mammoth into smaller >> print/whatever functions. >> How about it? > Hi Zdenek, > > I saw what you committed to CVS and all that I can say is "wow, this > guy really does not want me to submit a patch ever again". > > Modifying my patch to make the indentation 10x worse, while not > actually reducing the amount of difference, which is supposedly what > your complaint above is all about, then committing it without even > giving me a chance to give any feedback is a total amature move. It's > clear that you don't really have any respect for contributors nor any > real idea about what it takes to write professional code, so count me > out... I'm more than capable of maintaining my own fork of ipmitool > without having to deal with ridiculous code formatting arguments. > > Please take my name off this patch. I do not want my name associated with the > mess that you committed. > > When I see a commit in cvs which says "run lindent on all code, added > coding style document", then maybe I'll think about contributing back > any of my work. > > thanks > dan > > ------------------------------------------------------------------------------ > Precog is a next-generation analytics platform capable of advanced > analytics on semi-structured data. The platform includes APIs for building > apps and a phenomenal toolset for data science. Developers can use > our toolset for easy data analysis & visualization. Get a free account! > http://www2.precog.com/precogplatform/slashdotnewsletter > _______________________________________________ > Ipmitool-devel mailing list > Ipmitool-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ipmitool-devel > ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
