On Mon, Apr 22, 2013 at 2:40 PM, Jim Mankovich <jm...@hp.com> wrote: > > I fully agree with Dan in that there is no good reason to change existing > indentation for code. It simply obfuscates real changes and makes > application > of patches problematic. > > -- Jim Mankovich | jm...@hp.com (US Mountain Time) -- >
In fairness, I did change some of the indentation so that lines would not wrap 80 columns, but I did it just in the parts of the code which I was changing. Yes, I probably should have did it in two separate patches, but I didn't really have time to separate them. For the one of the other patch series, I did separate the changes from the formatting changes, but for this one I just didn't have time. If it's _that_ big of a deal, people can apply the patch and use diff -w or cvs diff -w to ignore the indentation changes. The problem is to take those changes that I did, make the formatting much, much, much worse by ensuring that _all_ lines wrap around 80 columns, add tons of totally unnecessary indentation as if just to spite me, all with the resulting patch yielding almost exactly the same number of lines of changes, but with the code looking 10x worse, _then_ committing it without any ack or feedback or opportunity to fix anything is just flat out rude and unprofessional. thanks dan ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
