Ok, let's fork this discussion. On Wed, Jul 17, 2013 at 9:28 PM, Dan Gora <dan.g...@gmail.com> wrote: > On Wed, Jul 17, 2013 at 4:21 PM, Zdenek Styblik > <zdenek.styb...@gmail.com> wrote: >> On Wed, Jul 17, 2013 at 9:11 PM, Dan Gora <dan.g...@gmail.com> wrote: >>> On Wed, Jul 17, 2013 at 4:06 PM, Zdenek Styblik >>> <zdenek.styb...@gmail.com> wrote: >>> >>>>> I posted 6 patches back on Apr 29, 2013 to fix the issues we had with >>>>> removing the -Wno-unused-result flag from CFLAGS that never got >>>>> reviewed or acked or anything. This was issue #3608759, now is issue >>>>> #65 http://sourceforge.net/p/ipmitool/patches/65/. >>>>> >>>> >>>> As it says in comments - this one particular thing is on hold. Jim >>>> will provide details, if necessary. >>> >>> I read the comments. It was on hold because of the warnings generated >>> when the flag was removed. That's why I created the patches to fix >>> the warnings.. >>> >> >> I see. But everything that was on tracker, s1-s9, is committed now. If >> these patches weren't attached to any ticket, then yes, they've got >> skipped for sure. > > yeah I saw that my last patches finally got merged.. thank you.. > > >> Strange since you're the one whom created the ticket in the first >> place. But SF.net acts in very strange ways. > > I think that you can change tickets because you're an Admin. Since > I'm a nobody, I cannot do anything, even touch my own tickets... > sigh... >
You're sort of right. They've improved the site and what you say is really true. >> Hm. Well, you can send it again to me and I'll see if I have it. But >> as I said. If it wasn't attached to any ticket, then I'm sure they've >> got skipped. In such case, please create a new ticket and attach these >> patches. > > ok, I'll send them again. > Nah, don't do that. Send everything you have to me, I'll check what I got and let you know what/if anything is missing on my drive. It will less overhead for me, I think. Now, I've compiled ipmitool-cvs with and without ``-Wno-unused-results'' and I see no difference on STDERR what so ever. I see couple warnings I should address, though. I think ``-Wno-unused-results'' can be removed now. Jim? > >> No guarantees (at least from me) on commit prior 1.8.13 release >> though, as there are still some issues that have to be fixed prior >> 1.8.13 and they're, well, planned. This, sort of, isn't. > > Well it's all part of patch #65... and they were submitted back in > Apr.. and they are fairly simple. > > Either way.. It fixes a fairly major regression that breaks builds, > but it's up to you, I guess. > > > d Just ... uh ... let's panic later. :) I mean. If we're talking about the only one thing that's left, as there is nothing else left than this as far as I know, it's no work. If we're talking about, say, 10 more patches in need of some sort of code review and what not, then it would mean some work. I know we've talked about why it shouldn't be removed now and why it was put on hold. I'm just lazy to digging through mailing to find out right now. As I said, there is still time. Z. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
