On Thu, Jul 25, 2013 at 4:28 PM, Dan Gora <dan.g...@gmail.com> wrote: [...] > > What I mean is that the changes that you added to my changes do not > change the generated code. They just add more words to the source > code. > > Changing: > > fseek(fd, blah, blah); > to > tmp = fseek(fd, blah, blah); > > then never looking at 'tmp' will generate the exact same object code > because 'tmp' will just be optimized out. Therefore it is unnecessary > to write the 'tmp =' part. That's why I said that the extra changes > are unnecessary. They do not change anything in the program's > behavior or functionality. If you add the checks of these return > codes, that _will_ change the program's behavior (I personally think > that it's kind of unnecessary, but...). >
I see. Well, somebody should check those return values, but that's a different story, I guess :) [...] >> There are still those(two) scanf() patches left. I want to look at >> these closer, because it seems tricky to handle scanf() correctly. > > It's really not _that_ tricky. It returns the number of things that > it scanned in correctly. > >> I mean, not just patch it up. > > Well I didn't just patch it up.. I tried to handle them correctly. > Here is what I had in mind: http://stackoverflow.com/questions/2430303/disadvantages-of-scanf http://stackoverflow.com/questions/9457325/how-to-use-sscanf-correctly-and-safely https://www.securecoding.cert.org/confluence/display/seccode/INT05-C.+Do+not+use+input+functions+to+convert+character+data+if+they+cannot+handle+all+possible+inputs http://blog.markloiseau.com/2012/02/two-safer-alternatives-to-scanf/ [...] > > oh man.. that's great to hear. It just so happens there is a tool > 'cvs2git' which does a great job of converting the CVS tree to git. > That's what I originally used. We just need a list of contributors so > that we can properly map the email address names used in cvs to real > names. > > http://cvs2svn.tigris.org/cvs2git.html > > I ran it once and everything looked really good in it. It saved all > the old revisions and tagged all the releases in what looked to me > like the right place. > > The other option is to just chose some point and start the git repo > from that point, but it would be nice to have the full change history > if possible. > > I'm sure that SF.net supports git.. From there we should just be able > to push a git tree to it and it should "just work". > > I'd be willing to work on this if everyone is ok with potentially moving to > git. > > thanks > dan I know there are scripts to convert CVS to Git and such. What I meant is it seems SF.net doesn't provide any means they would do it for the project itself. In other words, DIY. Anyway, I'd leave all such changes after 1.8.13 is released which is going to be soon now anyway. Z. ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
