On Tue, Aug 6, 2013 at 3:32 PM, Zdenek Styblik <zdenek.styb...@gmail.com> wrote: > On Tue, Aug 6, 2013 at 8:16 PM, Dan Gora <d...@adax.com> wrote: >> As for me, I'd like to try and get the changes to be able to remove >> the -Wno-unused-return flag from the Makefile since that breaks >> builds. There are several patches pending to be merged for that (ID >> 65: Fixes for configure.in for cross compilation). >> > > Stupid me. I forgot about these. However, we're talking about RC not release. > >> I also have two patches for ipmi_picmg.c that I'd like to try and get >> in if possible. One is to change atoi to use the str2* > > Huh? Where? I see no atoi() in ipmi_picmg.c. However, I see one atoi() > in ipmi_hpmfwupg.c which has slipped through. How's that even > possible, garrr! >
ok, sorry.. I did the patch against an older version.. I didn't see that those were fixed already... Never mind then... > Is it really crucial to get it into 1.8.13? eh... >> Also Dmitry has some good looking changes for ipmi_hpmfwupg.c that he >> submitted yesterday, but I don't think that they apply cleanly to the >> CVS root. I don't know if he has any plans to try and fix those up or >> not, but it would probably be nice to have. >> > > Again, same question. We have 1.8.12 for a year now; we know 1.8.13 is > going to be released for some time now, yet out of the blue new fixes, > very important no doubt, start rolling as the date comes closer. > I know I'm being sarcastic, I know I'm raining on the parade, I'm > sorry(not really), but somebody has to do it. We could go on like this > until the very last day. So let's say no. Let's say leave it for > 1.8.14 which could be released anytime, say, 3+ months after 1.8.13, > depending on man power and pressure. I think there is enough of bugs > that go unfixed already and are going to slip into another release. That's fine.. I just thought that if it's going to be another year before the 1.8.14 release, that it's probably better to do it now if possible. > No, but somebody has to review all of that. And if I knew how to > express next degree of being tight of time, I'd. Me, personally, I'll > be glad to fininish #65 mentioned above, DCMI, SEL and at most couple > reviews aside. As I said, there was plenty of time and it's kind of > proven this ``one more feature'' thing can go on forever. That's fine with me.. I'll submit the one patch for ipmi_picmg.c.. It's three lines of printf. You can include it if you'd like.. It's not pressing. thanks d ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
