davidradl commented on code in PR #26640:
URL: https://github.com/apache/flink/pull/26640#discussion_r2157379666
##########
docs/layouts/shortcodes/generated/expert_rocksdb_section.html:
##########
@@ -14,6 +14,12 @@
<td>Integer</td>
<td>The number of threads (per stateful operator) used to transfer
(download and upload) files in RocksDBStateBackend.If negative, the common (TM)
IO thread pool is used (see cluster.io-pool.size)</td>
</tr>
+ <tr>
+ <td><h5>state.backend.rocksdb.checkpoint.upload-jitter</h5></td>
+ <td style="word-wrap: break-word;">0 ms</td>
+ <td>Duration</td>
+ <td>The time interval used to create jitter for each checkpoint
file upload.</td>
Review Comment:
I am not an expert on state to be able to confirm this is the best way. I
will leave that to a committer. Thank you for your feedback:
1. OK I assume there is no IOException or nested Exception that would
identify this.
2. I suggest that we include these considerations in the docs as it is
difficult for the user to know when to set jitter otherwise. If we think that
checkpoint interval and jitter duration need to be set sensibly together , can
we validate that the jitter duration is less than the checkpoint interval? Can
you write a test to force an out of order checkpoint by testing with
combinations of these values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
