mxm commented on code in PR #26640:
URL: https://github.com/apache/flink/pull/26640#discussion_r2174450820
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBStateUploader.java:
##########
@@ -32,32 +32,46 @@
import org.apache.flink.util.concurrent.FutureUtils;
import org.apache.flink.util.function.CheckedSupplier;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import javax.annotation.Nonnull;
import java.io.Closeable;
import java.io.IOException;
import java.io.InputStream;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.time.Duration;
import java.util.ArrayList;
import java.util.List;
+import java.util.Random;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
+import java.util.function.Consumer;
import java.util.stream.Collectors;
/** Help class for uploading RocksDB state files. */
public class RocksDBStateUploader implements Closeable {
+ private static final Logger LOG =
LoggerFactory.getLogger(RocksDBStateUploader.class);
private static final int READ_BUFFER_SIZE = 16 * 1024;
-
+ private final Duration uploadJitter;
+ private final Random random;
private final RocksDBStateDataTransferHelper transfer;
+ private final JitterConsumer jitterConsumer;
@VisibleForTesting
- public RocksDBStateUploader(int numberOfSnapshottingThreads) {
-
this(RocksDBStateDataTransferHelper.forThreadNum(numberOfSnapshottingThreads));
+ public RocksDBStateUploader(int numberOfSnapshottingThreads, Duration
uploadJitter) {
+ this(
+
RocksDBStateDataTransferHelper.forThreadNum(numberOfSnapshottingThreads),
+ uploadJitter);
}
- public RocksDBStateUploader(RocksDBStateDataTransferHelper transfer) {
+ public RocksDBStateUploader(RocksDBStateDataTransferHelper transfer,
Duration uploadJitter) {
this.transfer = transfer;
+ this.uploadJitter = uploadJitter;
+ this.jitterConsumer = new JitterConsumer();
Review Comment:
```suggestion
this.jitterConsumer = new SleepConsumer();
```
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBStateUploader.java:
##########
@@ -32,32 +32,46 @@
import org.apache.flink.util.concurrent.FutureUtils;
import org.apache.flink.util.function.CheckedSupplier;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import javax.annotation.Nonnull;
import java.io.Closeable;
import java.io.IOException;
import java.io.InputStream;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.time.Duration;
import java.util.ArrayList;
import java.util.List;
+import java.util.Random;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
+import java.util.function.Consumer;
import java.util.stream.Collectors;
/** Help class for uploading RocksDB state files. */
public class RocksDBStateUploader implements Closeable {
+ private static final Logger LOG =
LoggerFactory.getLogger(RocksDBStateUploader.class);
private static final int READ_BUFFER_SIZE = 16 * 1024;
-
+ private final Duration uploadJitter;
+ private final Random random;
Review Comment:
Actually, I think we can replace all calls with `Math.random()` which is
already a static instance.
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBStateUploader.java:
##########
@@ -32,32 +32,46 @@
import org.apache.flink.util.concurrent.FutureUtils;
import org.apache.flink.util.function.CheckedSupplier;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import javax.annotation.Nonnull;
import java.io.Closeable;
import java.io.IOException;
import java.io.InputStream;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.time.Duration;
import java.util.ArrayList;
import java.util.List;
+import java.util.Random;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
+import java.util.function.Consumer;
import java.util.stream.Collectors;
/** Help class for uploading RocksDB state files. */
public class RocksDBStateUploader implements Closeable {
+ private static final Logger LOG =
LoggerFactory.getLogger(RocksDBStateUploader.class);
private static final int READ_BUFFER_SIZE = 16 * 1024;
-
+ private final Duration uploadJitter;
+ private final Random random;
Review Comment:
Can we make this `static`. It's going to be used once per TaskManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
