davidradl commented on code in PR #26640:
URL: https://github.com/apache/flink/pull/26640#discussion_r2166943735
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBStateUploader.java:
##########
@@ -180,6 +194,28 @@ private HandleAndLocalPath uploadLocalFileToCheckpointFs(
}
}
+ @VisibleForTesting
+ void applyJitter(Consumer<Long> consumer) {
+ if (uploadJitter.isZero()) {
+ return;
+ }
+
+ long milliseconds = random.nextLong(0, uploadJitter.toMillis() + 1);
+ consumer.accept(milliseconds);
+ }
+
+ static class JitterConsumer implements Consumer<Long> {
+
+ @Override
+ public void accept(Long milliseconds) {
+ try {
+ Thread.sleep(milliseconds);
+ } catch (InterruptedException e) {
+ LOG.error("Fail to apply jitter in RocksDBStateUploader.", e);
Review Comment:
nit: Maybe make this message a little nicer:
Fail to apply jitter in RocksDBStateUploader -> Jitter sleep for n
milliseconds was interrupted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
