davidradl commented on code in PR #26640:
URL: https://github.com/apache/flink/pull/26640#discussion_r2174756479
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBStateUploader.java:
##########
@@ -180,6 +196,31 @@ private HandleAndLocalPath uploadLocalFileToCheckpointFs(
}
}
+ @VisibleForTesting
+ void applyJitter(Consumer<Long> consumer) {
+ if (uploadJitter.isZero()) {
+ return;
+ }
+
+ long milliseconds = random.nextLong(0, uploadJitter.toMillis() + 1);
+ consumer.accept(milliseconds);
+ }
+
+ static class JitterConsumer implements Consumer<Long> {
+
+ @Override
+ public void accept(Long milliseconds) {
+ try {
+ Thread.sleep(milliseconds);
+ } catch (InterruptedException e) {
+ LOG.error(
+ "Fail to apply {} milliseconds jitter in
RocksDBStateUploader.",
Review Comment:
nit: This reads strangely. I am not sure the phrase failed to apply
represents an interrupted sleep. imho I would say:
Jitter sleep for n milliseconds was interrupted in RocksDBStateUploader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
