och5351 commented on code in PR #27874:
URL: https://github.com/apache/flink/pull/27874#discussion_r3025373853
##########
flink-runtime-web/web-dashboard/src/app/interfaces/job-rescales.ts:
##########
@@ -16,6 +16,76 @@
* limitations under the License.
*/
+export type RescalesHistories = RescalesHistory[];
+
+export interface RescalesHistory {
+ rescaleUuid: string;
+ resourceRequirementsUuid: string;
+ rescaleAttemptId: number;
+ vertices: object;
+ slots: object;
+ schedulerStates: unknown[];
+ startTimestampInMillis: number;
+ endTimestampInMillis: number;
+ terminalState: string;
+ triggerCause: string;
+ terminatedReason: string;
+ expand?: boolean;
+}
+
+export interface RescalesDetailHistory {
+ rescaleUuid: string;
+ resourceRequirementsUuid: string;
+ rescaleAttemptId: number;
+ vertices: { [vertexId: string]: RescaleVertex };
+ slots: { [slotSharingGroupId: string]: RescaleSlot };
+ schedulerStates: SchedulerState[];
+ startTimestampInMillis: number;
+ endTimestampInMillis: number;
+ terminalState: string;
+ triggerCause: string;
+ terminatedReason: string;
+}
Review Comment:
Hi @RocMarshal!
Thank you for the review :)
Regarding your first question about renaming to JobRescaleDetails:
That sounds great! I'll make that change and request your review again.
Regarding your second question about merging the two interfaces:
You make a good point. However, I think they should remain separate because
they're used
for different API endpoints. JobRescaleDetails can extend JobRescaleHistory
since:
- JobRescaleHistory: /jobs/:jobid/rescales/history
- JobRescaleDetails: /jobs/:jobid/rescales/details/:rescaleuuid
Does that approach work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
