och5351 commented on code in PR #27874:
URL: https://github.com/apache/flink/pull/27874#discussion_r3025881637
##########
flink-runtime-web/web-dashboard/src/app/interfaces/job-rescales.ts:
##########
@@ -16,6 +16,76 @@
* limitations under the License.
*/
+export type RescalesHistories = RescalesHistory[];
+
+export interface RescalesHistory {
+ rescaleUuid: string;
+ resourceRequirementsUuid: string;
+ rescaleAttemptId: number;
+ vertices: object;
+ slots: object;
+ schedulerStates: unknown[];
+ startTimestampInMillis: number;
+ endTimestampInMillis: number;
+ terminalState: string;
+ triggerCause: string;
+ terminatedReason: string;
+ expand?: boolean;
+}
+
+export interface RescalesDetailHistory {
+ rescaleUuid: string;
+ resourceRequirementsUuid: string;
+ rescaleAttemptId: number;
+ vertices: { [vertexId: string]: RescaleVertex };
+ slots: { [slotSharingGroupId: string]: RescaleSlot };
+ schedulerStates: SchedulerState[];
+ startTimestampInMillis: number;
+ endTimestampInMillis: number;
+ terminalState: string;
+ triggerCause: string;
+ terminatedReason: string;
+}
Review Comment:
@RocMarshal
Thank you for considering my suggestions!
I agree with your naming approach. The revised names make much more sense
and better reflect the actual data structure:
- BriefJobRescaleDetails (for RescalesHistory)
- RescalesHistory (for RescalesHistories)
- JobRescaleDetails (for RescalesDetailHistory)
I'll make these changes and push a new commit for review.
Once all reviews are complete, I'll squash all the commits together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
