RocMarshal commented on PR #27874: URL: https://github.com/apache/flink/pull/27874#issuecomment-4184063057
I checked UI of the PR locally with https://github.com/apache/flink/pull/27705. checked: - [x] Refresh button related logic and correctness - [x] Rescales page showing logic - [x] The table basic information showing logic, like tooltip, table headers, columns...,etc. LGTM +1 on the whole just a few of issues: - [ ] highlighted in the Fig. <img width="3046" height="1662" alt="image" src="https://github.com/user-attachments/assets/0e8acaf9-80cc-46fb-918e-8614f5eb10d4"; /> <img width="2708" height="640" alt="image" src="https://github.com/user-attachments/assets/d49e4cbf-c613-4567-8b9f-00b0b63f57a6"; /> - [ ] When I click the Rescales/History from Rescales/Configuration page, the new Rescales/History page did not request the `/jobs/:jobid/rescales/history` interface， We expect that in this case, the corresponding API can be requested again. Thanks @och5351 for the hard work. I conducted some manual tests locally and found some minor issues, PTAL next week:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
