RocMarshal commented on code in PR #27874:
URL: https://github.com/apache/flink/pull/27874#discussion_r3050298889
##########
flink-runtime-web/web-dashboard/src/app/pages/job/rescales/job-rescales.component.ts:
##########
@@ -107,4 +129,41 @@ export class JobRescalesComponent implements OnInit,
OnDestroy {
public refresh(): void {
this.refresh$.next();
}
+
+ public trackById(item: BriefJobRescaleDetails): string {
+ return item.rescaleUuid;
+ }
+
+ public onExpandChange(history: BriefJobRescaleDetails, expanded: boolean):
void {
Review Comment:
history -> jobRescaleDetails
##########
flink-runtime-web/web-dashboard/src/app/pages/job/rescales/job-rescales.component.ts:
##########
@@ -54,8 +66,12 @@ import { JobLocalService } from '../job-local.service';
]
})
export class JobRescalesComponent implements OnInit, OnDestroy {
- public rescalesConfig?: RescalesConfig;
+ public rescalesHistories?: RescalesHistory;
Review Comment:
rescalesHistories -> rescalesHistory
##########
flink-runtime-web/web-dashboard/src/app/pages/job/rescales/job-rescales.component.html:
##########
@@ -21,7 +21,356 @@
[nzSize]="'small'"
[nzAnimated]="{ inkBar: true, tabPane: false }"
[nzTabBarExtraContent]="extraTemplate"
+ (nzSelectedIndexChange)="refresh()"
>
+ <nz-tab nzTitle="History">
+ <nz-table
+ class="no-border small"
+ [nzSize]="'small'"
+ [nzData]="rescalesHistories || []"
+ [nzFrontPagination]="false"
+ [nzShowPagination]="false"
+ >
+ <thead>
+ <tr>
+ <th nzWidth="70px" nzAlign="center"></th>
+ <th
+ nz-tooltip
+ nzTooltipTitle="The unique ID in Rescale consists of 32
hexadecimal characters"
+ >
+ <strong>Rescale UUID</strong>
+ </th>
+ <th
+ nz-tooltip
+ nzTooltipTitle="The number ID of Rescale attempts that occurred
under the same resource requirements"
+ >
+ <strong>Attempt ID</strong>
+ </th>
+ <th
+ nz-tooltip
+ nzTooltipTitle="The unique ID of resource requirements consists of
32 hexadecimal characters"
+ >
+ <strong>Requirements ID</strong>
+ </th>
+ <th nz-tooltip nzTooltipTitle="The reason that triggers the target
Rescale">
+ <strong>Trigger Cause</strong>
+ </th>
+ <th nz-tooltip nzTooltipTitle="The end state of the target Rescale">
+ <strong>Terminal State</strong>
+ </th>
+ <th
+ nz-tooltip
+ nzTooltipTitle="The reason for the completion or termination of
the target Rescale"
+ >
+ <strong>Terminated Reason</strong>
+ </th>
+ <th nz-tooltip nzTooltipTitle="The start time of the target Rescale">
+ <strong>Start Time</strong>
+ </th>
+ <th
+ nz-tooltip
+ nzTooltipTitle="Duration from the start of the rescale to its
completion or until now"
+ >
+ <strong>Duration</strong>
+ </th>
+ <th nz-tooltip nzTooltipTitle="The end time of the target Rescale">
+ <strong>End Time</strong>
+ </th>
+ </tr>
+ </thead>
+ <tbody>
+ <ng-container *ngFor="let history of rescalesHistories; trackBy:
trackById">
Review Comment:
history -> jobRescaleDetails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
