Re: [PR] [FLINK-38899][runtime-web] Introduce the Rescales/History sub-page for streaming jobs with the adaptive scheduler enabled [flink]

[via GitHub]

och5351 commented on PR #27874:
URL: https://github.com/apache/flink/pull/27874#issuecomment-4190109465

   > I checked UI of the PR locally with #27705.
   > 
   > checked:
   > 
   > * [x]  Refresh button related logic and correctness
   > * [x]  Rescales page showing logic
   > * [x]  The table basic information showing logic, like tooltip, table 
headers, columns...,etc.
   > 
   > LGTM +1 on the whole just a few of issues:
   > 
   > * [ ]  highlighted in the Fig.
   > 
   > <img alt="image" width="2000" height="1662" 
src="https://private-user-images.githubusercontent.com/64569824/573576980-0e8acaf9-80cc-46fb-918e-8614f5eb10d4.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzU0NDM5NzMsIm5iZiI6MTc3NTQ0MzY3MywicGF0aCI6Ii82NDU2OTgyNC81NzM1NzY5ODAtMGU4YWNhZjktODBjYy00NmZiLTkxOGUtODYxNGY1ZWIxMGQ0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA0MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNDA2VDAyNDc1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxZTg0M2Y1Yzk4OTJhNGRhNzg1YThkYzE4ZjJmMmM1MmU4NTIyYzBmMjQ4ZTNlYWZmOTJjMDE0MGU4Zjc5NjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.G91sz6iPKoy6VqM7LGZsoz2d2r4lMN9jJWwPAmlTeTk";>
 <img alt="image" width="2000" height="640" 
src="https://private-user-images.githubusercontent.com/64569824/573578763-d49e4cbf-c613-4567-8b9f-00b0b63f57a6.png?jwt=e
 
yJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzU0NDM5NzMsIm5iZiI6MTc3NTQ0MzY3MywicGF0aCI6Ii82NDU2OTgyNC81NzM1Nzg3NjMtZDQ5ZTRjYmYtYzYxMy00NTY3LThiOWYtMDBiMGI2M2Y1N2E2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA0MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNDA2VDAyNDc1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUwMmRkNWIyMDVjMWRhZDc2MWUxMzg2MzEwNzY2MGZjNjY2OWNmYTM0ODMwMjU5NWU4MDc2ZDE0Yjg1YWFhNjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pYayLvZiltBFzbFuluy6rg7mN9OxUk57J4ZDEgATj4U">
   > * [ ]   When I click the Rescales/History from Rescales/Configuration 
page, the  new Rescales/History page did not request the 
`/jobs/:jobid/rescales/history`  interface， We expect that in this case, the 
corresponding API can be requested again.
   > 
   > Thanks @och5351 for the hard work. I conducted some manual tests locally 
and found some minor issues, PTAL next week:)
   
   Hi, @RocMarshal !
   Thank you for your review.
   
   Could you please review this again?
   
   ## While watining
   
   <img width="2268" height="945" alt="image" 
src="https://github.com/user-attachments/assets/93fcd9b4-fe0c-4d6b-858d-ab1e4f05444d";
 />
   
   ## Done
   
   <img width="2254" height="879" alt="image" 
src="https://github.com/user-attachments/assets/ad65bbf2-3ff5-4f16-a607-ebe347fda175";
 />
   
   * While wating : 6f8d480aebb85b0da94a6db13fba4e14f114841f
   * Refresh : 3824aab5e7c928df8fc706fed485bcdda90bcc8c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org