featzhang commented on PR #27774:
URL: https://github.com/apache/flink/pull/27774#issuecomment-4362801542
## ๐งน Cleanup of unrelated diff
Pushed `ed51cb2` to further reduce reviewer cognitive load by removing
diff noise that wasn't contributing to the feature:
### What was removed
1. **`job-manager-logs.component.ts`** and
**`task-manager-logs.component.ts`**
were reverted to master. The entire diff in those two files was
cosmetic โ import quote style, spacing inside destructuring, folding
of multi-line imports and indentation of `@Component` decorators.
None of it was needed for this PR and kept the blast radius confined
to the Top-N feature.
2. **`angular.json`** โ dropped the `"analytics": "1079c058-..."` key
that had been added automatically by a local `ng` invocation. Shared
project config should not carry a single developer's tracking UUID.
3. **`overview.component.html`** โ the list title was restored from
`'Running Application List with topCpuConsumers'` back to
`'Running Application List'`. The former was a debug label left
over from an early prototype.
4. **`overview.component.ts`** and **`application-overview.component.ts`** โ
removed the `ChangeDetectorRef` injection and `cdr.markForCheck()`
call. With the Top-N fields now simple empty-array defaults on the
components (the real data is fetched and rendered by the dedicated
`JobTopNMetricComponent`), there is no observable to trigger and no
manual change detection is required. Also tidied a double blank line
between `ngOnInit` and `ngOnDestroy`.
### Impact on the diff
- Deleted lines vs `upstream/master` went from **40 โ 6**.
- The remaining 6 deletions are all legitimate (trailing commas on
array items or single-line โ multi-line import conversions).
### Verification
- `npx tsc --noEmit` in `flink-runtime-web/web-dashboard` passes clean.
- No functional behavior change: the Top-N dashboard is still wired
through `JobTopNMetricComponent` + `TopNMetricsService`, which is
where it belongs.
cc @reviewers โ this should be the final polish pass before review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
