featzhang commented on PR #27774:
URL: https://github.com/apache/flink/pull/27774#issuecomment-4363506084
### ๐งน Scope tightening: Top N Metrics now only appears on the Job detail page
Following the end-to-end review, the Top N Metrics REST endpoint is
fundamentally **job-scoped** (it takes a `jobid` path parameter), so showing
the `<flink-topn-metrics>` placeholder on cluster-wide landing pages (
`/overview` and `/application/overview`) produced an always-empty block with no
meaningful data.
This commit removes the placeholder so the feature is presented only where
it has real data:
| Page | Before | After |
|---|---|---|
| `/overview` | empty Top N block | removed โ matches upstream |
| `/application/overview` | empty Top N block | removed โ matches upstream |
| `/job/{running\|completed}/{jid}/topn-metric` | real data via
`TopNMetricsService` | unchanged โ
|
#### What was removed
- `<flink-topn-metrics>` template markup from both overview templates
- `TopNMetricsComponent` and unused DTO imports in both component classes
- Unused `topCpuConsumers` / `topBackpressureOperators` /
`topGcIntensiveTasks` fields
- Orphan `flink-topn-metrics` style rule in `overview.component.less`
#### Diff vs `upstream/master` for these two pages
```
$ git diff --stat upstream/master -- flink-runtime-web/.../overview/
flink-runtime-web/.../application/overview/
(no output โ both pages now exactly match master)
```
#### Verification
- `tsc --noEmit` passes with no errors
- `RuntimeRestAPIStabilityTest` passes (snapshot corrected in the previous
commit)
- `RuntimeOpenRestAPIDocsCompletenessITCase` passes
- `TopNMetricsHandlerTest` (10) + `TopNQueryParameterTest` (5) all green
This keeps the PR surface minimal and focused on the job-level Top N
dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
