[
https://issues.apache.org/jira/browse/IMPALA-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798507#comment-16798507
]
ASF subversion and git services commented on IMPALA-8317:
---------------------------------------------------------
Commit 685318423415cd6235adf47fe8026383f5e99a60 in impala's branch
refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6853184 ]
IMPALA-8317: Add support for list type flags in Impala shell config file
This patch adds support for list type flags in Impala shell config
file, i.e. those that use action="append", such as --var and
--query_option. To make it less error-prone, this patch also updates
the logic for bool flags in the config file to also look at the
correct type from the argument parser instead of relying on whether or
not the default values are set in impala_shell_config_defaults.py.
Testing:
- Added a new test for list type flags
- Ran all shell E2E tests
Change-Id: I824ca15b4e1064a391b13deef9cecd34c928ef73
Reviewed-on: http://gerrit.cloudera.org:8080/12781
Reviewed-by: Fredy Wijaya <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> impala-shell's config_file should be parsed correctly for 'keyval'
> ------------------------------------------------------------------
>
> Key: IMPALA-8317
> URL: https://issues.apache.org/jira/browse/IMPALA-8317
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Affects Versions: Impala 2.12.0, Impala 3.1.0
> Reporter: Vincent Tran
> Assignee: Fredy Wijaya
> Priority: Minor
> Fix For: Impala 3.3.0
>
>
> [root@kiwi-2 ~]# cat ~/.impalarc
> [impala]
> keyval=foo=customers
> [root@kiwi-2 ~]# impala-shell --ssl -q 'set'
> Starting Impala Shell without Kerberos authentication
> SSL is enabled. Impala server certificates will NOT be verified (set
> --ca_cert to change)
> {color:red}for keyval in keyvals:
> Tokenized keyval: "f"
> keyvals: "foo=customers"{color}
> Error: Could not parse key-value "f". It must follow the pattern "KEY=VALUE".
> Usage: impala_shell.py [options]
> It's apparent that the "KEY=VAL" string passed in is tokenized by characters
> here:
> https://github.com/apache/impala/blob/969dea84f41cfccf863b14904958a5d2be91983f/shell/impala_shell.py#L1512
> An immediate fix might be to cast options.keyval to an array
> ([options.keyval]):
> https://github.com/apache/impala/blob/969dea84f41cfccf863b14904958a5d2be91983f/shell/impala_shell.py#L1719
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
