[
https://issues.apache.org/jira/browse/IMPALA-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799856#comment-16799856
]
ASF subversion and git services commented on IMPALA-8317:
---------------------------------------------------------
Commit eb95c912cb7e720caf66388942b4e94d95e95658 in impala's branch
refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=eb95c91 ]
IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell
IMPALA-8317 added a patch that uses OrderedDict, which is not available
on Python 2.6 or lower. The patch in IMPALA-8317 also requires a newer
version of configparser to handle duplicate keys, which is not available
in Python 2.6. This patch fixes the issue by using the OrderedDict from
ordereddict third-party library when running on Python 2.6 or lower and
using configparser from the backport.
Testing:
- Ran all E2E shell tests on Python 2.6 and 2.7
Change-Id: Iab1a33542319e9bb75d806bfd38b158995b54aa9
Reviewed-on: http://gerrit.cloudera.org:8080/12830
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> impala-shell's config_file should be parsed correctly for 'keyval'
> ------------------------------------------------------------------
>
> Key: IMPALA-8317
> URL: https://issues.apache.org/jira/browse/IMPALA-8317
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Affects Versions: Impala 2.12.0, Impala 3.1.0
> Reporter: Vincent Tran
> Assignee: Fredy Wijaya
> Priority: Minor
> Fix For: Impala 3.3.0
>
>
> [root@kiwi-2 ~]# cat ~/.impalarc
> [impala]
> keyval=foo=customers
> [root@kiwi-2 ~]# impala-shell --ssl -q 'set'
> Starting Impala Shell without Kerberos authentication
> SSL is enabled. Impala server certificates will NOT be verified (set
> --ca_cert to change)
> {color:red}for keyval in keyvals:
> Tokenized keyval: "f"
> keyvals: "foo=customers"{color}
> Error: Could not parse key-value "f". It must follow the pattern "KEY=VALUE".
> Usage: impala_shell.py [options]
> It's apparent that the "KEY=VAL" string passed in is tokenized by characters
> here:
> https://github.com/apache/impala/blob/969dea84f41cfccf863b14904958a5d2be91983f/shell/impala_shell.py#L1512
> An immediate fix might be to cast options.keyval to an array
> ([options.keyval]):
> https://github.com/apache/impala/blob/969dea84f41cfccf863b14904958a5d2be91983f/shell/impala_shell.py#L1719
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
