[
https://issues.apache.org/jira/browse/IMPALA-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802001#comment-16802001
]
ASF subversion and git services commented on IMPALA-8317:
---------------------------------------------------------
Commit ed9e1d499b3a3e6e30386dc11e55b6907eaaf409 in impala's branch
refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ed9e1d4 ]
IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337
Fixes in IMPALA-8317 and IMPALA-8337 introduced third-party dependencies
in Impala shell which is problematic in multi-Python environment. This
patch rewrites the fixes using an alternative solution when dealing with
duplicate options without any third-party dependencies. For example:
[impala]
keyval=msg1=hello,keyval=msg2=world
Testing:
- Ran all shell tests on Python 2.6 and 2.7.
- Ran make_shell_tarball.sh and ran Impala shell from the tarball
without any issue.
Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539
Reviewed-on: http://gerrit.cloudera.org:8080/12844
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> impala-shell's config_file should be parsed correctly for 'keyval'
> ------------------------------------------------------------------
>
> Key: IMPALA-8317
> URL: https://issues.apache.org/jira/browse/IMPALA-8317
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Affects Versions: Impala 2.12.0, Impala 3.1.0
> Reporter: Vincent Tran
> Assignee: Fredy Wijaya
> Priority: Minor
> Fix For: Impala 3.3.0
>
>
> [root@kiwi-2 ~]# cat ~/.impalarc
> [impala]
> keyval=foo=customers
> [root@kiwi-2 ~]# impala-shell --ssl -q 'set'
> Starting Impala Shell without Kerberos authentication
> SSL is enabled. Impala server certificates will NOT be verified (set
> --ca_cert to change)
> {color:red}for keyval in keyvals:
> Tokenized keyval: "f"
> keyvals: "foo=customers"{color}
> Error: Could not parse key-value "f". It must follow the pattern "KEY=VALUE".
> Usage: impala_shell.py [options]
> It's apparent that the "KEY=VAL" string passed in is tokenized by characters
> here:
> https://github.com/apache/impala/blob/969dea84f41cfccf863b14904958a5d2be91983f/shell/impala_shell.py#L1512
> An immediate fix might be to cast options.keyval to an array
> ([options.keyval]):
> https://github.com/apache/impala/blob/969dea84f41cfccf863b14904958a5d2be91983f/shell/impala_shell.py#L1719
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
