[ 
https://issues.apache.org/jira/browse/IMPALA-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130451#comment-17130451
 ] 

Csaba Ringhofer commented on IMPALA-5078:
-----------------------------------------

Currently expr-test.cc is above 10000 lines, which makes github usage 
problematic - the non-raw github pages do not display the full file + github 
searches do not return from these cut off lines.

> Break up expr-test.cc
> ---------------------
>
>                 Key: IMPALA-5078
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5078
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Henry Robinson
>            Priority: Minor
>              Labels: newbie, ramp-up
>
> {{expr-test.cc}} clocks in at 7129 lines, which is about enough for my emacs 
> to start slowing down a bit. Let's see if we can refactor it enough to have a 
> couple of test files. Maybe moving all the string instructions into a 
> separate {{expr-string-test.cc}}, and having a common header will be enough 
> to make it a bit more manageable. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to