[
https://issues.apache.org/jira/browse/IMPALA-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147889#comment-17147889
]
Andrew Sherman commented on IMPALA-5078:
----------------------------------------
[~sy117] probaly the important thing os to split this file up into 2 or 3
files. Ideally there should be a rationale for the split. One example would be
to separate out the string instructions but you can consider other ideas.
> Break up expr-test.cc
> ---------------------
>
> Key: IMPALA-5078
> URL: https://issues.apache.org/jira/browse/IMPALA-5078
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Henry Robinson
> Assignee: Sean Yeh
> Priority: Minor
> Labels: newbie, ramp-up
>
> {{expr-test.cc}} clocks in at 7129 lines, which is about enough for my emacs
> to start slowing down a bit. Let's see if we can refactor it enough to have a
> couple of test files. Maybe moving all the string instructions into a
> separate {{expr-string-test.cc}}, and having a common header will be enough
> to make it a bit more manageable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
