[
https://issues.apache.org/jira/browse/IMPALA-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876865#comment-17876865
]
ASF subversion and git services commented on IMPALA-13323:
----------------------------------------------------------
Commit 6eabff9eab8c96b9cc6e68506dc9173722a07ad1 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6eabff9ea ]
IMPALA-13323: Remove redundant tests in test_join_queries.py
Before this patch, test_join_queries.py is expensive to run in
exhaustive exploration because it run many test dimension permutation,
but actually never exercise some of the dimensions. Those redundant
tests are follows:
Have mt_dop dimension, but not exercising it:
- test_outer_to_inner_joins
- test_single_node_nested_loop_joins
Have batch_size dimension but not exercising it:
- test_outer_to_inner_joins
- test_single_node_nested_loop_joins
- test_single_node_nested_loop_joins_exhaustive
- test_semi_joins_exhaustive
Have enable_outer_join_to_inner_transformation dimension but not
exercising it:
- All TestJoinQueries except test_outer_to_inner_joins
test_miss_tuple_joins is also valid to run with much fewer test
dimension because it mainly test correctness of predicate pushdown
during planning.
This patch reorganize test_join_queries.py into several test classes
where exec option dimensions are clearly declared and correctly
exercised without duplication. The reduction are follows:
Before patch:
41 core tests, 526 exhaustive tests
After patch:
28 core tests, 93 exhaustive tests
Added validate_exec_option_dimension() in impala_test_suite.py to log
WARNING if there is a dimension name matching query option name that is
not also registered in 'exec_option' name. That log can be observed in
log file such as logs/ee_tests/results/TEST-impala-parallel.xml. Also
fix couple flake8 issues found at impala_test_suite.py
Change-Id: I76efa82dad59dbb9f58a36a4a2938b5f73a382f6
Reviewed-on: http://gerrit.cloudera.org:8080/21716
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Michael Smith <[email protected]>
> Remove redundant tests in test_join_queries.py
> ----------------------------------------------
>
> Key: IMPALA-13323
> URL: https://issues.apache.org/jira/browse/IMPALA-13323
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Affects Versions: Impala 4.4.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Minor
> Fix For: Impala 4.5.0
>
>
> test_join_queries.py is expensive to run in exhaustive exploration because it
> run many test dimension permutation, but actually never exercise some of the
> dimensions. Those redundant tests are follows:
> * Have mt_dop dimension, but not exercising it:
> test_outer_to_inner_joins
> test_single_node_nested_loop_joins
> * Have batch_size dimension but not exercising it:
> test_outer_to_inner_joins
> test_single_node_nested_loop_joins
> test_single_node_nested_loop_joins_exhaustive
> test_semi_joins_exhaustive
> * Have enable_outer_join_to_inner_transformation dimension but not
> exercising it:
> All TestJoinQueries except test_outer_to_inner_joins
> test_miss_tuple_joins is also valid to run with much fewer test dimension
> because it mainly test correctness of predicate pushdown during planning.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
