[
https://issues.apache.org/jira/browse/IMPALA-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879703#comment-17879703
]
ASF subversion and git services commented on IMPALA-13323:
----------------------------------------------------------
Commit de1a925cb79931d786301e58a8422d0930ae983c in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=de1a925cb ]
IMPALA-13349: Fix remaining tests with unexercised exec_option
This patch fixes remaining tests that has unexercised exec_option.
Some test reorganization are done to clarify their test dimension
declaration. The WARNING log added by IMPALA-13323 is turned into
pytest.fail() with error message suggestion on how to fix it.
Fixed some flake8 warnings and error as well.
Testing:
- Pass EE and custom cluster tests in exhaustive exploration.
Change-Id: I33bb4b6c4ff50b55a082460dd9944d2aa3511e11
Reviewed-on: http://gerrit.cloudera.org:8080/21743
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Remove redundant tests in test_join_queries.py
> ----------------------------------------------
>
> Key: IMPALA-13323
> URL: https://issues.apache.org/jira/browse/IMPALA-13323
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Affects Versions: Impala 4.4.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Minor
> Fix For: Impala 4.5.0
>
>
> test_join_queries.py is expensive to run in exhaustive exploration because it
> run many test dimension permutation, but actually never exercise some of the
> dimensions. Those redundant tests are follows:
> * Have mt_dop dimension, but not exercising it:
> test_outer_to_inner_joins
> test_single_node_nested_loop_joins
> * Have batch_size dimension but not exercising it:
> test_outer_to_inner_joins
> test_single_node_nested_loop_joins
> test_single_node_nested_loop_joins_exhaustive
> test_semi_joins_exhaustive
> * Have enable_outer_join_to_inner_transformation dimension but not
> exercising it:
> All TestJoinQueries except test_outer_to_inner_joins
> test_miss_tuple_joins is also valid to run with much fewer test dimension
> because it mainly test correctness of predicate pushdown during planning.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
