[
https://issues.apache.org/jira/browse/IMPALA-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879047#comment-17879047
]
ASF subversion and git services commented on IMPALA-13323:
----------------------------------------------------------
Commit 2db68dff4870cc7f5c5b40388fdaf0eb0fdcf617 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=2db68dff4 ]
IMPALA-13341: Fix mismatch exec option values in py.test files
IMPALA-13323 added WARNING log if, for independently declared
query option 'key',
vector.get_value('exec_option')['key'] != vector.get_value('key').
This patch eliminate such WARNING logs by fixing exec option declaration
in test_mem_usage_scaling.py and test_update_stress.py, the only test
producing the WARNING log. Here are the summary of the patch:
- Declare 'mem_limit' using add_exec_option_dimension helper function in
TestQueryMemLimitScaling so that 'mem_limit' dimension is not
silently ignored.
- Declare 'batch_size' using create_exec_option_dimension helper
function in TestIcebergV2UpdateStress to override the default
'exec_option' dimension (containing batch_size=0) that initialized by
ImpalaTestSuite.add_test_dimensions().
- Rename 'mem_limit' dimension to 'test_mem_limit' dimension for
subclasses of TestLowMemoryLimits. The final 'mem_limit' option
is still calculated from 'test_mem_limit' dimension.
- Change the LOG.warn() into pytest.fail() to prevent new tests from
repeating the same issue.
- Address few flake8 warnings and errors.
Testing:
- Pass exhaustive tests for test_mem_usage_scaling.py and
test_update_stress.py.
Change-Id: Ic34187782c51c6d6fc0a688c9c5f72bf0cb2d45c
Reviewed-on: http://gerrit.cloudera.org:8080/21733
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Remove redundant tests in test_join_queries.py
> ----------------------------------------------
>
> Key: IMPALA-13323
> URL: https://issues.apache.org/jira/browse/IMPALA-13323
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Affects Versions: Impala 4.4.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Minor
> Fix For: Impala 4.5.0
>
>
> test_join_queries.py is expensive to run in exhaustive exploration because it
> run many test dimension permutation, but actually never exercise some of the
> dimensions. Those redundant tests are follows:
> * Have mt_dop dimension, but not exercising it:
> test_outer_to_inner_joins
> test_single_node_nested_loop_joins
> * Have batch_size dimension but not exercising it:
> test_outer_to_inner_joins
> test_single_node_nested_loop_joins
> test_single_node_nested_loop_joins_exhaustive
> test_semi_joins_exhaustive
> * Have enable_outer_join_to_inner_transformation dimension but not
> exercising it:
> All TestJoinQueries except test_outer_to_inner_joins
> test_miss_tuple_joins is also valid to run with much fewer test dimension
> because it mainly test correctness of predicate pushdown during planning.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
