[
https://issues.apache.org/jira/browse/ARTEMIS-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052771#comment-16052771
]
ASF GitHub Bot commented on ARTEMIS-1235:
-----------------------------------------
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1345
ARTEMIS-1235 Support queue and address deletion when broker.xml changes
Ensure default is that still deletion is not done, it is opt in only.
Add extra configuration to address-settings to be able to control / enable
address/queue deletion by pattern, rather than a global toggle.
Add support in the reload logic to remove address and/or queues if the
address matches an address setting, where it is enabled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis
ARTEMIS-1235
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1345
----
commit 78dd1d6b959173ad380b9c81de6a28bedd517ddc
Author: Michael Andre Pearce <[email protected]>
Date: 2017-06-17T05:43:02Z
ARTEMIS-1235 Support the ability to enable queue and address deletion when
broker.xml changes
Add extra configuration to address-settings to be able to control / enable
address/queue deletion by pattern, rather than a global toggle.
Add support in the reload logic to remove address and/or queues if the
address matches an address setting, where it is enabled.
----
> Support the ability to enable queue and address deletion when broker.xml
> changes
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-1235
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1235
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Michael Andre Pearce
>
> Currently on config reload, as per:
> https://activemq.apache.org/artemis/docs/2.1.0/config-reload.html
> Once the configuration file is changed (broker.xml) the following modules
> will be reloaded automatically:
> Address Settings
> Security Settings
> Diverts
> Addresses & queues
> Notice: Address & queues won't be removed upon reload, given the risk of
> losing messages. You may execute explicit CLI or Management operations to
> remove destinations.
> Where an organisation uses tools like puppet or chef and need to fully change
> manage the broker they need an ability to delete queues and topics also via
> the config, as these tools control state of systems by config. Like wise in
> these scenario's where such tools are used to control state of a system
> typically an organisation will have controls and pre-prod environments where
> they push config through the environments as such risk of issue is removed re
> data loss / or accepted risk, as would have been pre-validated in
> non-ciritical non-prod envs.
> The default behaviour should be as is today (e.g. delete still doesn't
> occur), but an optional toggle so that queue's and address's are sync'd
> removed inline with the broker xml.
> Ideally it should be possible to toggle this ability by address pattern so if
> some address's you don't wish controlled this way and others you do, this
> should be possible.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
