[
https://issues.apache.org/jira/browse/ARTEMIS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059833#comment-16059833
]
ASF GitHub Bot commented on ARTEMIS-1248:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1361
@franz1981 if you were using a thread local on activeMQBuffer and
unsafeByteBufWrapper I would agree with you on saving GC.
however... Page won't last much longer on a regular scenario. The Page will
be served through PageCursorProviderImpl::getPageCache(); So.. this will be
read basically only once... or if the cache on the PageCursorProviderImpl is
beyond the limit, then the whole Page object would go away.
so, you won't ever read it twice if you get the opportunity of reusing the
field you're trying to reuse. it will probably be from a different object at
the time you get there.
So, I would say either use a ThreadLocal, or keep it the way it is.. since
the Objects you are caching will be GCed from the released Page when the cache
is full anyways.
> Reduce garbage while Paging
> ---------------------------
>
> Key: ARTEMIS-1248
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1248
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> While Paging It reuse the ActiveMQBuffer used to perform operations on the
> underlying SequentialFile.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
