[
https://issues.apache.org/jira/browse/ARTEMIS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060871#comment-16060871
]
ASF GitHub Bot commented on ARTEMIS-1248:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1361
@clebertsuconic Having only one instance would be optimal, but considering
that is a simple wrapper with no byte[] or off-heap memory allocated into it,
just avoiding 100K it's a good compromise IMHO.
About the changes on the NIO file factory, I've already tried (and
measured) a solution with the Netty pools before pushing that version, but I
found it to not be a good solution in this case for several reasons:
1. it is slower if compared to the TLAB slution I've implemented (the pool
is not shared across threads)
2, it grows the overall memory footprint and can be cause of leaks
3. it doesn't work nicely with "plain" ByteBuffers, forcing the use of
ByteBuf (not a good idea for normal file API)
> Reduce garbage while Paging
> ---------------------------
>
> Key: ARTEMIS-1248
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1248
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> While Paging It reuse the ActiveMQBuffer used to perform operations on the
> underlying SequentialFile.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
