[jira] [Commented] (ARTEMIS-1248) Reduce garbage while Paging

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ARTEMIS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060538#comment-16060538
 ] 

ASF GitHub Bot commented on ARTEMIS-1248:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1361
  
    @michaelandrepearce @clebertsuconic 
    You're right: these are the results of a test writing 100 Pages of 10MB 
with messages of 100 bytes.
    Just 2 notes:
    - I've used the Artemis JVM default settings: -XX:+PrintClassHistogram 
-XX:+UseG1GC -XX:+AggressiveOpts -XX:+UseFastAccessorMethods -Xms512M -Xmx2G.
    With smaller HEAP the effect is even more pronounced.
    - I've forced a GC just at the beginning to have the HEAP clean.
    
    Old version:
    
![unpooled](https://user-images.githubusercontent.com/13125299/27471968-ee3e8036-57f9-11e7-962f-c8c5ae1f1276.png)
    
![unpooled_gc](https://user-images.githubusercontent.com/13125299/27471969-ee3f12a8-57f9-11e7-96f1-88103375c08d.png)
    
    New version:
    
![pooled](https://user-images.githubusercontent.com/13125299/27472080-59ff4fda-57fa-11e7-9645-34aac2446281.png)
    
![pooled_gc](https://user-images.githubusercontent.com/13125299/27472079-59fcd516-57fa-11e7-8d81-0d566e041c58.png)
     wdyt?
    



> Reduce garbage while Paging
> ---------------------------
>
>                 Key: ARTEMIS-1248
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1248
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>
> While Paging It reuse the ActiveMQBuffer used to perform operations on the 
> underlying SequentialFile.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)