[
https://issues.apache.org/jira/browse/ARTEMIS-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334500#comment-16334500
]
ASF GitHub Bot commented on ARTEMIS-1626:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1800
@gaohoward
I understand, but often a failed test is expected to fail cleanly (without
having leaking threads): having that information ignored could affect anyway
the other tests and probably it is hiding leaks that is better to know (eg
oracle JDBC has leaking driver clean threads that is better to have it reported
on failed tests too: thay won't stop never even if the thread is killed
manually).
Have I misunderstood the change?
> Disable thread leak check for failing tests
> -------------------------------------------
>
> Key: ARTEMIS-1626
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1626
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Fix For: 2.5.0
>
>
> The ThreadLeakCheckRule is used to check thread leaks
> after each test is finished. However when a test fails, it is
> not necessary to check leaking threads because the test
> failure should be fixed anyway. And leaking threads in a
> failed test may well be a result of the failure (once the test
> is fixed the thread leak may be gone).
> If a failed test also leaks threads, it takes a long time before
> the thread leak check finishes (60 seconds checking time),
> thus it takes a long time to finish, especially when tests are
> run in batches with failures.
> So to improve this, it should be reasonable to just enable
> the thread leaking check for each test passes, and disable
> the check when a test fails.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
