[
https://issues.apache.org/jira/browse/ARTEMIS-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334536#comment-16334536
]
ASF GitHub Bot commented on ARTEMIS-1626:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1800
@gaohoward the idea world is far from reality.. there are tests that will
be failing forever on the testsuite and people will ignore them.. a result will
be a mess that people won't know where the leaks are coming from again.
The ThreadLeak Rule has prevented leaked threads to fail non related tests..
and the threadleak rule is not only logging, but it's also trying to
interrupt these leaked threads...
Lets not regress on that please!
We can do a faster check (not wait for a whole minute on failted tests..
and we would only logg. instead of fail).. it's a simple change.
> Disable thread leak check for failing tests
> -------------------------------------------
>
> Key: ARTEMIS-1626
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1626
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Fix For: 2.5.0
>
>
> The ThreadLeakCheckRule is used to check thread leaks
> after each test is finished. However when a test fails, it is
> not necessary to check leaking threads because the test
> failure should be fixed anyway. And leaking threads in a
> failed test may well be a result of the failure (once the test
> is fixed the thread leak may be gone).
> If a failed test also leaks threads, it takes a long time before
> the thread leak check finishes (60 seconds checking time),
> thus it takes a long time to finish, especially when tests are
> run in batches with failures.
> So to improve this, it should be reasonable to just enable
> the thread leaking check for each test passes, and disable
> the check when a test fails.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
