[
https://issues.apache.org/jira/browse/ARTEMIS-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334610#comment-16334610
]
ASF GitHub Bot commented on ARTEMIS-1626:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1800
@gaohoward I undestand your points you've showed on my questions, but as
@clebertsuconic has pointed
> the ideal world is far from reality.. there are tests that will be
failing forever on the testsuite and people will ignore them
I agree with that and I think we should try to keep more isolated than
possible (if possible) tests (failing or not) just for this reason: just
logging the leaks would be enough for me.
While dealing with very long running tests who will read the test reports
need to rely that 2 different runs are comparable somehow and hiding this
information won't help doing it.
I understand the need to make the process more agile and to aim "0 tests
failures" and I think that just logging would be great.
I hope to have explained better what I'm worried about
> Disable thread leak check for failing tests
> -------------------------------------------
>
> Key: ARTEMIS-1626
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1626
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Fix For: 2.5.0
>
>
> The ThreadLeakCheckRule is used to check thread leaks
> after each test is finished. However when a test fails, it is
> not necessary to check leaking threads because the test
> failure should be fixed anyway. And leaking threads in a
> failed test may well be a result of the failure (once the test
> is fixed the thread leak may be gone).
> If a failed test also leaks threads, it takes a long time before
> the thread leak check finishes (60 seconds checking time),
> thus it takes a long time to finish, especially when tests are
> run in batches with failures.
> So to improve this, it should be reasonable to just enable
> the thread leaking check for each test passes, and disable
> the check when a test fails.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
