[
https://issues.apache.org/jira/browse/ARTEMIS-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352412#comment-16352412
]
ASF GitHub Bot commented on ARTEMIS-1656:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1849#discussion_r165979537
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
@@ -713,12 +730,16 @@ public void reconnect(AMQConnectionContext
existingContext, ConnectionInfo info)
context.incRefCount();
}
+ private static void traceSendCommand(Command command) {
+ ActiveMQServerLogger.LOGGER.trace("sending " + command);
+ }
+
/**
* This will answer with commands to the client
*/
public boolean sendCommand(final Command command) {
- if (ActiveMQServerLogger.LOGGER.isTraceEnabled()) {
- ActiveMQServerLogger.LOGGER.trace("sending " + command);
+ if (ACTIVE_MQ_SERVER_LOGGER_TRACE_ENABLED) {
--- End diff --
Why not fix it at the route in jboss logger? Surely then it be global fix.
Im much more happy to fix things at root source.
> OpenWire scalability improvements
> ---------------------------------
>
> Key: ARTEMIS-1656
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1656
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> OpenWire is using the synchronized OpenWireFormat instance belonging to
> OpenWireProtocolManager: it won't allow to scale with the number of
> connections.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
