[ https://issues.apache.org/jira/browse/ARTEMIS-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352523#comment-16352523 ]
ASF GitHub Bot commented on ARTEMIS-1656: ----------------------------------------- Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1849#discussion_r166001057 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java --- @@ -713,12 +730,16 @@ public void reconnect(AMQConnectionContext existingContext, ConnectionInfo info) context.incRefCount(); } + private static void traceSendCommand(Command command) { + ActiveMQServerLogger.LOGGER.trace("sending " + command); + } + /** * This will answer with commands to the client */ public boolean sendCommand(final Command command) { - if (ActiveMQServerLogger.LOGGER.isTraceEnabled()) { - ActiveMQServerLogger.LOGGER.trace("sending " + command); + if (ACTIVE_MQ_SERVER_LOGGER_TRACE_ENABLED) { --- End diff -- You're quite right, probably I will revert it but it is actually an issue and probably could be turned into a lock-free way: actually it really create a point of contentions for any send of messages, affecting responses and consumers all together...not good! > OpenWire scalability improvements > --------------------------------- > > Key: ARTEMIS-1656 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1656 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Francesco Nigro > Assignee: Francesco Nigro > Priority: Minor > > OpenWire is using the synchronized OpenWireFormat instance belonging to > OpenWireProtocolManager: it won't allow to scale with the number of > connections. -- This message was sent by Atlassian JIRA (v7.6.3#76005)